-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update errorprone config for Java 10 #1265
Update errorprone config for Java 10 #1265
Conversation
Well, it builds on Java 10. Can't say the same for the CI running Java 8 though. |
3303b60
to
4bf9920
Compare
Yea... I think I just fixed that. If you wouldn't mind trying again. |
Works on Java 10, but CI still seems unhappy. :( |
Oops. I missed a critical piece of docs: "Error Prone requires at least a JDK 9 compiler to be used as a javac plugin." So this should be merged when we decide to go to Java 10. |
I guess we can deal with the warnings until that happens then. |
Is there no way to support both Java 8 and Java 10? We kind of want both to be supported by the build setup. |
The trusty if statement worked well here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Note: |
Awesome! We'll keep an eye out for that. |
Basically followed the instructions here: google/error-prone#860
@auscompgeek if you wouldn't mind checking this.